bbejeck commented on code in PR #17321:
URL: https://github.com/apache/kafka/pull/17321#discussion_r1809554541
##########
tests/kafkatest/tests/streams/streams_cooperative_rebalance_upgrade_test.py:
##########
@@ -68,9 +67,8 @@ def __init__(self, test_context):
acks=1)
@cluster(num_nodes=8)
- @matrix(upgrade_from_version=streams_eager_rebalance_upgrade_versions)
- def test_upgrade_to_cooperative_rebalance(self, upgrade_from_version):
- self.zookeeper.start()
+ @matrix(upgrade_from_version=streams_eager_rebalance_upgrade_versions,
metadata_quorum=[quorum.combined_kraft])
Review Comment:
Required to indicate to use KRaft for metadata quorum. Failing to do so
without a `@matrix` annotation results in this error as the test will default
to ZK without it.
```File "/opt/kafka-dev/tests/kafkatest/services/kafka/kafka.py", line 541,
in security_config
zk_sasl=self.zk.zk_sasl if self.quorum_info.using_zk else False,
zk_tls=self.zk_client_secure,
AttributeError: 'NoneType' object has no attribute 'zk_sasl'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
