FrankYang0529 commented on PR #17444: URL: https://github.com/apache/kafka/pull/17444#issuecomment-2424700046
Hi @dajac, the PR is ready. I did following change: * Move `Murmur3` from `org.apache.kafka.streams.state.internals` to `org.apache.kafka.common.hash`. * In `TopicMetadata`, use `TreeMap` and `TreeSet` to store `partitionRacks`. * Add `hashSubscriptionMetadata` to `Utils`. In it, use `TreeMap` to make sure the`Map<String, TopicMetadata>` is sorted. * Remove `ConsumerGroupPartitionMetadataValue` and `ShareGroupPartitionMetadataValue`, so we don't store subscription metadata in `__consumer_offsets`. Remove related `GroupMetadataManager#replay` functions as well. * Add hash of subscription metadata to `ConsumerGroupMetadataValue`. * Add `TimelineLong subscribedTopicMetadataHash` to `ModernGroup`. * Remove `TimelineHashMap<String, TopicMetadata> subscribedTopicMetadata` from `ModernGroup`. The CI result looks good. Could you help me review again when you have time? Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
