dajac commented on code in PR #17444:
URL: https://github.com/apache/kafka/pull/17444#discussion_r1816397624
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/ModernGroup.java:
##########
@@ -388,10 +386,25 @@ public Map<String, TopicMetadata>
computeSubscriptionMetadata(
subscribedTopicNames.forEach((topicName, count) -> {
TopicImage topicImage = topicsImage.getTopic(topicName);
if (topicImage != null) {
+ Map<Integer, Set<String>> partitionRacks = new HashMap<>();
+ topicImage.partitions().forEach((partition,
partitionRegistration) -> {
+ Set<String> racks = new HashSet<>();
+ for (int replica : partitionRegistration.replicas) {
+ Optional<String> rackOptional =
clusterImage.broker(replica).rack();
Review Comment:
In this case, it would trigger a "rebalance" by bumping the group epoch and
it would trigger the computation of a new assignment for the group. In this
particular example, the assignment should not change because, as you said,
there is no reason to change it. Hence it would effectively be a no-op for the
consumers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
