frankvicky commented on code in PR #17549:
URL: https://github.com/apache/kafka/pull/17549#discussion_r1814557313
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractMembershipManager.java:
##########
@@ -1234,8 +1245,8 @@ protected void resetEpoch() {
protected void updateMemberEpoch(int newEpoch) {
boolean newEpochReceived = this.memberEpoch != newEpoch;
this.memberEpoch = newEpoch;
- // Simply notify based on epoch change only, given that the member
will never receive a
- // new member ID without an epoch (member ID is only assigned when it
joins the group).
+ // Simply notify based on epoch changes only, since the member will
generate a member ID
+ // at startup, and it will remain unchanged for its entire lifetime.
if (newEpochReceived) {
Review Comment:
Thanks for feedback. 😺
I’m wondering about the initial value of `MemberInfo.memberId` if we replace
it with a `String` instead of `Optional<String>`. Should we use an empty string
as its initial value ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
