lianetm commented on code in PR #17549:
URL: https://github.com/apache/kafka/pull/17549#discussion_r1814943048
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##########
@@ -1293,17 +1287,16 @@ public void setInflightCommitStatus(final boolean
inflightCommitStatus) {
}
static class MemberInfo {
- Optional<String> memberId;
+ String memberId = "";
Review Comment:
uhm true. Then what about we simply do a kind of
commitManager.setMemberId(memberId) from the membershipMgr constructor (right
after assigning the commitRequestManager)? The point I'm after in the commitMgr
is to clearly separate the `memberId` (set once, never updated) from the
`memberEpoch` (may be updated and the commitMgr needs to know about those
changes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
