lianetm commented on code in PR #17549:
URL: https://github.com/apache/kafka/pull/17549#discussion_r1815339271
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerMembershipManager.java:
##########
@@ -188,6 +186,7 @@ public ConsumerMembershipManager(String groupId,
this.rebalanceTimeoutMs = rebalanceTimeoutMs;
this.serverAssignor = serverAssignor;
this.commitRequestManager = commitRequestManager;
+ this.commitRequestManager.memberInfo.memberId = this.memberId;
Review Comment:
well from your
[comment](https://github.com/apache/kafka/pull/17549#discussion_r1815213715)
above it seems that even if we set the member ID explicitly, it is still needed
to keep it on the `onMemberEpochUpdated` as param right? if so then it's
probably not worth the hassle, we can just remove this line and stay with the
memberID updated on the listeners as part of the onMemberEpochUpdated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
