ableegoldman commented on code in PR #17702:
URL: https://github.com/apache/kafka/pull/17702#discussion_r1830567644
##########
streams/test-utils/src/main/java/org/apache/kafka/streams/TopologyTestDriver.java:
##########
@@ -738,7 +737,14 @@ private Queue<ProducerRecord<byte[], byte[]>>
getRecordsQueue(final String topic
public final <K, V> TestInputTopic<K, V> createInputTopic(final String
topicName,
Review Comment:
Also wondering why all these methods are final -- I could have addressed
this issue in our code without this PR if I could just override these methods.
Are we concerned about users doing this..? And why?
I figure this change actually would need a KIP so I left it out, but I'd
like to remove the `final` from these unless someone knows a good reason for
doing this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
