lucasbru commented on code in PR #17702:
URL: https://github.com/apache/kafka/pull/17702#discussion_r1830647793
##########
streams/test-utils/src/main/java/org/apache/kafka/streams/TopologyTestDriver.java:
##########
@@ -738,7 +737,14 @@ private Queue<ProducerRecord<byte[], byte[]>>
getRecordsQueue(final String topic
public final <K, V> TestInputTopic<K, V> createInputTopic(final String
topicName,
Review Comment:
You are right, you'd need a KIP for removing it. I'm fine with merging this
fix without removing the `final`.
For removing the `final` -- it does make sense to restrict the surface area
for extending the public interface. I'm not sure why we'd need to override
those. But this is something for the KIP discussion anyways, if you want to
write one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
