bbejeck commented on code in PR #17702:
URL: https://github.com/apache/kafka/pull/17702#discussion_r1831512988
##########
streams/test-utils/src/main/java/org/apache/kafka/streams/TopologyTestDriver.java:
##########
@@ -738,7 +737,14 @@ private Queue<ProducerRecord<byte[], byte[]>>
getRecordsQueue(final String topic
public final <K, V> TestInputTopic<K, V> createInputTopic(final String
topicName,
final
Serializer<K> keySerializer,
final
Serializer<V> valueSerializer) {
- return new TestInputTopic<>(this, topicName, keySerializer,
valueSerializer, Instant.now(), Duration.ZERO);
+ return new TestInputTopic<>(
+ this,
+ topicName,
+ keySerializer,
+ valueSerializer,
+ Instant.ofEpochMilli(mockWallClockTime.milliseconds()),
Review Comment:
Yeah, I agree this doesn't need a KIP, plus there's an overload where users
can provide their own time if needed. Although, you make a great point about
synchronizing the time with the driver.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
