FrankYang0529 commented on code in PR #17958:
URL: https://github.com/apache/kafka/pull/17958#discussion_r1865949820
##########
clients/src/main/resources/common/message/ConsumerGroupDescribeResponse.json:
##########
@@ -69,7 +70,9 @@
{ "name": "Assignment", "type": "Assignment", "versions": "0+",
"about": "The current assignment." },
{ "name": "TargetAssignment", "type": "Assignment", "versions":
"0+",
- "about": "The target assignment." }
+ "about": "The target assignment." },
+ { "name": "IsClassic", "type": "bool", "versions": "1+",
"ignorable": true,
+ "about": "True for classic member." }
Review Comment:
Hi @dajac / @chia7712, thanks for the review. It looks like we can implement
it in Admin side. If `ConsumerGroupDescribeResponse#version` is `0`, set
`MemberDescription#isClassic` as `Optional.empty()`. If
`ConsumerGroupDescribeResponse#version` is `1`, set
`MemberDescription#isClassic` as `Optional.of(value)`. I change the KIP to
align this discussion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
