dajac commented on code in PR #17958:
URL: https://github.com/apache/kafka/pull/17958#discussion_r1867445609
##########
clients/src/main/resources/common/message/ConsumerGroupDescribeResponse.json:
##########
@@ -69,7 +70,9 @@
{ "name": "Assignment", "type": "Assignment", "versions": "0+",
"about": "The current assignment." },
{ "name": "TargetAssignment", "type": "Assignment", "versions":
"0+",
- "about": "The target assignment." }
+ "about": "The target assignment." },
+ { "name": "IsClassic", "type": "bool", "versions": "1+",
"ignorable": true,
+ "about": "True for classic member." }
Review Comment:
@chia7712 It is not about simplifying the code. It is about ensuring that we
have a well defined protocol and that folks implementing the protocol on the
client side do the right thing. With the byte, is is explicit in the protocol
that the value maybe undefined. With the boolean, they have to think about
taking into account the version in that decision. It is really easy to miss it
in my opinion. We use sentinels as default values in many places in the
protocol for this purpose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
