FrankYang0529 commented on code in PR #17958:
URL: https://github.com/apache/kafka/pull/17958#discussion_r1866056950
##########
clients/src/main/resources/common/message/ConsumerGroupDescribeResponse.json:
##########
@@ -69,7 +70,9 @@
{ "name": "Assignment", "type": "Assignment", "versions": "0+",
"about": "The current assignment." },
{ "name": "TargetAssignment", "type": "Assignment", "versions":
"0+",
- "about": "The target assignment." }
+ "about": "The target assignment." },
+ { "name": "IsClassic", "type": "bool", "versions": "1+",
"ignorable": true,
+ "about": "True for classic member." }
Review Comment:
Hi @dajac / @chia7712, I updated the PR to use `int8`. Although this
approach is more complicated, it provides more information than boolean. For
both types, we need to update document to clarify that `isClassic` only works
for RPC version 1 and above. I think we can focus on whether server complexity
is acceptable or not. For me, it's ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
