ijuma commented on code in PR #18384:
URL: https://github.com/apache/kafka/pull/18384#discussion_r1903143938
##########
core/src/main/scala/kafka/Kafka.scala:
##########
@@ -64,11 +64,7 @@ object Kafka extends Logging {
private def buildServer(props: Properties): Server = {
val config = KafkaConfig.fromProps(props, doLog = false)
if (config.requiresZookeeper) {
- new KafkaServer(
- config,
- Time.SYSTEM,
- threadNamePrefix = None
- )
+ throw new RuntimeException("ZooKeeper is not supported")
Review Comment:
I actually meant something else - I was asking whether we need to keep
`kafka.Kafka`. The answer is `yes` since it is still used for KRaft. But
looking at this in more detail, this exception message doesn't make sense in a
world where ZK is not supported since it will throw this when process roles is
empty.
We should simply remove this conditional code and leave it to `KafkaConfig`
to throw the appropriate exception if `processRoles` is empty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
