chia7712 commented on code in PR #18384:
URL: https://github.com/apache/kafka/pull/18384#discussion_r1903292608
##########
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##########
@@ -1068,8 +1059,7 @@ class DynamicListenerConfig(server: KafkaBroker) extends
BrokerReconfigurable wi
listenersToMap(newConfig.effectiveAdvertisedBrokerListeners))) {
verifyListenerRegistrationAlterationSupported()
server match {
- case kafkaServer: KafkaServer =>
kafkaServer.kafkaController.updateBrokerInfo(kafkaServer.createBrokerInfo)
- case _ => throw new RuntimeException("Unable to handle
non-kafkaServer")
+ case _ => throw new RuntimeException("Unable to handle reconfigure")
Review Comment:
> There's a bunch of other ZooKeeper related logic in this class so I was
planning to address them together in a follow up issue. Deleting KafkaServer
enables us to start removing other classes that depend on this one.
I'm ok to merge this and then address comments in the follow-up, because
there are many cleanup blocked by KafkaServer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
