chia7712 commented on code in PR #18384:
URL: https://github.com/apache/kafka/pull/18384#discussion_r1903175305
##########
core/src/main/scala/kafka/Kafka.scala:
##########
@@ -64,11 +64,7 @@ object Kafka extends Logging {
private def buildServer(props: Properties): Server = {
val config = KafkaConfig.fromProps(props, doLog = false)
if (config.requiresZookeeper) {
- new KafkaServer(
- config,
- Time.SYSTEM,
- threadNamePrefix = None
- )
+ throw new RuntimeException("ZooKeeper is not supported")
Review Comment:
Sorry for misunderstanding your comment
> We should simply remove this conditional code and leave it to KafkaConfig
to throw the appropriate exception if processRoles is empty.
make sense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
