ijuma commented on code in PR #18468:
URL: https://github.com/apache/kafka/pull/18468#discussion_r1911246721
##########
core/src/test/scala/unit/kafka/server/ReplicaFetcherThreadTest.scala:
##########
@@ -130,96 +128,12 @@ class ReplicaFetcherThreadTest {
ApiKeys.FETCH.latestVersion(true),
testingVersion.fetchRequestVersion
)
- assertEquals(
- ApiKeys.OFFSET_FOR_LEADER_EPOCH.latestVersion(true),
- testingVersion.offsetForLeaderEpochRequestVersion
- )
assertEquals(
ApiKeys.LIST_OFFSETS.latestVersion(true),
testingVersion.listOffsetRequestVersion
)
}
- @Disabled("KAFKA-18370")
- @Test
- def testFetchLeaderEpochRequestIfLastEpochDefinedForSomePartitions(): Unit =
{
Review Comment:
Sorry @junrao - I didn't fully understand. Are you saying we should _not_
remove these tests just yet or that it's ok to remove these and remove the rest
in a separate PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
