ijuma commented on code in PR #18468:
URL: https://github.com/apache/kafka/pull/18468#discussion_r1911723432
##########
clients/src/main/java/org/apache/kafka/common/requests/AlterPartitionRequest.java:
##########
@@ -68,14 +68,12 @@ public static class Builder extends
AbstractRequest.Builder<AlterPartitionReques
* @param data The data to be sent. Note that because the version of
the
* request is not known at this time, it is expected that
all
* topics have a topic id and a topic name set.
- * @param canUseTopicIds True if version 2 and above can be used.
*/
- public Builder(AlterPartitionRequestData data, boolean canUseTopicIds)
{
Review Comment:
The claim is that we're using protocol negotiation to decide the version to
use. The following is stated in `AlterPartitionManager.buildRequest`.
* While building the request, we don't know which version of the
AlterPartition API is
* supported by the controller. The final decision is taken when the
AlterPartitionRequest
* is built in the network client based on the advertised api versions of the
controller.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
