junrao commented on code in PR #18468:
URL: https://github.com/apache/kafka/pull/18468#discussion_r1911519969
##########
core/src/test/scala/unit/kafka/server/ReplicaFetcherThreadTest.scala:
##########
@@ -130,96 +128,12 @@ class ReplicaFetcherThreadTest {
ApiKeys.FETCH.latestVersion(true),
testingVersion.fetchRequestVersion
)
- assertEquals(
- ApiKeys.OFFSET_FOR_LEADER_EPOCH.latestVersion(true),
- testingVersion.offsetForLeaderEpochRequestVersion
- )
assertEquals(
ApiKeys.LIST_OFFSETS.latestVersion(true),
testingVersion.listOffsetRequestVersion
)
}
- @Disabled("KAFKA-18370")
- @Test
- def testFetchLeaderEpochRequestIfLastEpochDefinedForSomePartitions(): Unit =
{
Review Comment:
KAFKA-18370 says that we could remove these tests because 4.0 doesn't
support ZK anymore. This seems incorrect since this part of the code is
independent of the ZK change. However, it does seem that the
OffsetForLeaderEpochRequest is not really exercised because of the truncating
on fetch support. I am just not 100% sure. So, it would useful to try to remove
that part of the code first and then remove the corresponding tests.
cc @chia7712
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
