chia7712 commented on code in PR #18553:
URL: https://github.com/apache/kafka/pull/18553#discussion_r1918726582
##########
core/src/test/scala/unit/kafka/server/ReplicaFetcherThreadTest.scala:
##########
@@ -68,26 +68,24 @@ class ReplicaFetcherThreadTest {
private val brokerEndPoint = new BrokerEndPoint(0, "localhost", 1000)
private val failedPartitions = new FailedPartitions
- private val partitionStates = List(
- new UpdateMetadataRequestData.UpdateMetadataPartitionState()
- .setTopicName("topic1")
- .setPartitionIndex(0)
- .setControllerEpoch(0)
- .setLeader(0)
- .setLeaderEpoch(0),
- new UpdateMetadataRequestData.UpdateMetadataPartitionState()
- .setTopicName("topic2")
- .setPartitionIndex(0)
- .setControllerEpoch(0)
- .setLeader(0)
- .setLeaderEpoch(0),
- ).asJava
-
- private val updateMetadataRequest = new
UpdateMetadataRequest.Builder(ApiKeys.UPDATE_METADATA.latestVersion(),
- 0, 0, 0, partitionStates, Collections.emptyList(), topicIds.asJava).build()
- // TODO: support raft code?
- private var metadataCache = new ZkMetadataCache(0,
MetadataVersion.latestTesting(), BrokerFeatures.createEmpty())
- metadataCache.updateMetadata(0, updateMetadataRequest)
+ private val metadataDelta = new MetadataDelta(MetadataImage.EMPTY)
Review Comment:
I believe @TaiJuWu is suggesting that this data was previously used by
zk-related tests. Since these zk-related tests have already been removed, there
is no longer a need to set this data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
