TaiJuWu commented on code in PR #18553:
URL: https://github.com/apache/kafka/pull/18553#discussion_r1918738294
##########
core/src/test/scala/unit/kafka/server/ReplicaFetcherThreadTest.scala:
##########
@@ -68,26 +68,24 @@ class ReplicaFetcherThreadTest {
private val brokerEndPoint = new BrokerEndPoint(0, "localhost", 1000)
private val failedPartitions = new FailedPartitions
- private val partitionStates = List(
- new UpdateMetadataRequestData.UpdateMetadataPartitionState()
- .setTopicName("topic1")
- .setPartitionIndex(0)
- .setControllerEpoch(0)
- .setLeader(0)
- .setLeaderEpoch(0),
- new UpdateMetadataRequestData.UpdateMetadataPartitionState()
- .setTopicName("topic2")
- .setPartitionIndex(0)
- .setControllerEpoch(0)
- .setLeader(0)
- .setLeaderEpoch(0),
- ).asJava
-
- private val updateMetadataRequest = new
UpdateMetadataRequest.Builder(ApiKeys.UPDATE_METADATA.latestVersion(),
- 0, 0, 0, partitionStates, Collections.emptyList(), topicIds.asJava).build()
- // TODO: support raft code?
- private var metadataCache = new ZkMetadataCache(0,
MetadataVersion.latestTesting(), BrokerFeatures.createEmpty())
- metadataCache.updateMetadata(0, updateMetadataRequest)
+ private val metadataDelta = new MetadataDelta(MetadataImage.EMPTY)
Review Comment:
My bad. previous what I think was this setting is test for `IBP2.6` but it
was deleted by https://github.com/apache/kafka/pull/18468
After checking (checkout to 3.9 and deleted `metadataCache.updateMetadata`),
I found all tests are passed so I am not sure what it is for.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
