ijuma commented on code in PR #18553:
URL: https://github.com/apache/kafka/pull/18553#discussion_r1918737974
##########
core/src/test/scala/unit/kafka/server/ReplicaFetcherThreadTest.scala:
##########
@@ -68,26 +68,24 @@ class ReplicaFetcherThreadTest {
private val brokerEndPoint = new BrokerEndPoint(0, "localhost", 1000)
private val failedPartitions = new FailedPartitions
- private val partitionStates = List(
- new UpdateMetadataRequestData.UpdateMetadataPartitionState()
- .setTopicName("topic1")
- .setPartitionIndex(0)
- .setControllerEpoch(0)
- .setLeader(0)
- .setLeaderEpoch(0),
- new UpdateMetadataRequestData.UpdateMetadataPartitionState()
- .setTopicName("topic2")
- .setPartitionIndex(0)
- .setControllerEpoch(0)
- .setLeader(0)
- .setLeaderEpoch(0),
- ).asJava
-
- private val updateMetadataRequest = new
UpdateMetadataRequest.Builder(ApiKeys.UPDATE_METADATA.latestVersion(),
- 0, 0, 0, partitionStates, Collections.emptyList(), topicIds.asJava).build()
- // TODO: support raft code?
- private var metadataCache = new ZkMetadataCache(0,
MetadataVersion.latestTesting(), BrokerFeatures.createEmpty())
- metadataCache.updateMetadata(0, updateMetadataRequest)
+ private val metadataDelta = new MetadataDelta(MetadataImage.EMPTY)
Review Comment:
That seems a bit odd. This class is testing functionality that is
independent of zk. In such cases, we have to be very careful that we're
deleting tests that actually zk specific versus testing functionality that is
general but were never converted to the kraft way.
##########
core/src/test/scala/unit/kafka/server/ReplicaFetcherThreadTest.scala:
##########
@@ -68,26 +68,24 @@ class ReplicaFetcherThreadTest {
private val brokerEndPoint = new BrokerEndPoint(0, "localhost", 1000)
private val failedPartitions = new FailedPartitions
- private val partitionStates = List(
- new UpdateMetadataRequestData.UpdateMetadataPartitionState()
- .setTopicName("topic1")
- .setPartitionIndex(0)
- .setControllerEpoch(0)
- .setLeader(0)
- .setLeaderEpoch(0),
- new UpdateMetadataRequestData.UpdateMetadataPartitionState()
- .setTopicName("topic2")
- .setPartitionIndex(0)
- .setControllerEpoch(0)
- .setLeader(0)
- .setLeaderEpoch(0),
- ).asJava
-
- private val updateMetadataRequest = new
UpdateMetadataRequest.Builder(ApiKeys.UPDATE_METADATA.latestVersion(),
- 0, 0, 0, partitionStates, Collections.emptyList(), topicIds.asJava).build()
- // TODO: support raft code?
- private var metadataCache = new ZkMetadataCache(0,
MetadataVersion.latestTesting(), BrokerFeatures.createEmpty())
- metadataCache.updateMetadata(0, updateMetadataRequest)
+ private val metadataDelta = new MetadataDelta(MetadataImage.EMPTY)
Review Comment:
That seems a bit odd. This class is testing functionality that is
independent of zk. In such cases, we have to be very careful that we're
deleting tests that are actually zk specific versus testing functionality that
is general but were never converted to the kraft way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
