apoorvmittal10 commented on code in PR #18444:
URL: https://github.com/apache/kafka/pull/18444#discussion_r1918926272
##########
core/src/main/java/kafka/server/share/SharePartitionManager.java:
##########
@@ -361,24 +376,31 @@ public CompletableFuture<Map<TopicIdPartition,
ShareAcknowledgeResponseData.Part
}
});
- return mapAcknowledgementFutures(futuresMap);
+ return mapAcknowledgementFutures(futuresMap, Optional.empty());
}
- private CompletableFuture<Map<TopicIdPartition,
ShareAcknowledgeResponseData.PartitionData>>
mapAcknowledgementFutures(Map<TopicIdPartition, CompletableFuture<Throwable>>
futuresMap) {
+ private CompletableFuture<Map<TopicIdPartition,
ShareAcknowledgeResponseData.PartitionData>> mapAcknowledgementFutures(
+ Map<TopicIdPartition, CompletableFuture<Throwable>> futuresMap,
+ Optional<BiConsumer<Collection<String>, Boolean>> metricsHandler
Review Comment:
I got rid of 1 BiConsumer by passing BrokerTopicStats to ShareFetch as with
recent refactoring we can pass BrokerTopicStats to ShareFetch as the class is
moved to `server` module. The othe BiConsumer, I simplified to use Consumer. As
there exists fust 1 such functional call now hence skipped creating an
interface. Please let me know if you disagree.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
