apoorvmittal10 commented on code in PR #18444:
URL: https://github.com/apache/kafka/pull/18444#discussion_r1922820173
##########
core/src/main/java/kafka/server/share/SharePartitionManager.java:
##########
@@ -598,6 +632,12 @@ void processShareFetch(ShareFetch shareFetch) {
sharePartitions.put(topicIdPartition, sharePartition);
}
+ // Update the metrics for the topics for which we have received a
share fetch request.
+ topics.forEach(topic -> {
+
brokerTopicStats.allTopicsStats().totalShareFetchRequestRate().mark();
Review Comment:
I might be missing something here but this metrics is similar to
`TotalFetchRequestsPerSec` as it gives the aggregated view of the `all` topic
metrics. Are you suggesting that there should be a cleanup for existing metrics
as well to not emit the aggregated ones in future? Sorry I think I am missing
something basic here so thought to clarify prior making further change.
https://github.com/apache/kafka/blob/837fb1ed0250837c2d9578ce0e290abded75bcf8/storage/src/main/java/org/apache/kafka/storage/log/metrics/BrokerTopicMetrics.java#L43
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
