apoorvmittal10 commented on code in PR #18444:
URL: https://github.com/apache/kafka/pull/18444#discussion_r1920127046
##########
core/src/main/java/kafka/server/share/SharePartitionManager.java:
##########
@@ -302,7 +320,13 @@ public CompletableFuture<Map<TopicIdPartition,
ShareAcknowledgeResponseData.Part
}
});
- return mapAcknowledgementFutures(futures);
+ // Update the metrics for the topics for which we have received an
acknowledgement.
+ topics.forEach(topic -> {
+
brokerTopicStats.allTopicsStats().totalShareAcknowledgementRequestRate().mark();
Review Comment:
Yes, I agree with Andrew. That's the intent to track the ShareAcknowlwegment
request for topics. Explicit ack and share fetch request we ll track by
kafka.network request metrics, as you suggested in other comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
