chia7712 commented on code in PR #18444:
URL: https://github.com/apache/kafka/pull/18444#discussion_r1927445143
##########
core/src/main/java/kafka/server/share/SharePartitionManager.java:
##########
@@ -598,6 +632,12 @@ void processShareFetch(ShareFetch shareFetch) {
sharePartitions.put(topicIdPartition, sharePartition);
}
+ // Update the metrics for the topics for which we have received a
share fetch request.
+ topics.forEach(topic -> {
+
brokerTopicStats.allTopicsStats().totalShareFetchRequestRate().mark();
Review Comment:
> the former tracks an aggregated per topic
It seems we don't address that. It is based on topic-partition.
https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/server/ReplicaManager.scala#L1547
Producer request has similar behavior.
https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/server/ReplicaManager.scala#L1298
Maybe we should fix both fetch/produce metrics
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
