lianetm commented on code in PR #18737:
URL: https://github.com/apache/kafka/pull/18737#discussion_r1954506065
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##########
@@ -637,6 +634,11 @@ private void maybeUpdateLastSeenEpochIfNewer(final
Map<TopicPartition, OffsetAnd
});
}
+ public void updateTimerAndMaybeCommit(final long currentTimeMs) {
+ updateAutoCommitTimer(currentTimeMs);
+ maybeAutoCommitAsync();
Review Comment:
agree, related to the similar
[comment](https://github.com/apache/kafka/pull/18737#discussion_r1954494541)
above, all the same missing bit behind it imo:
> The application thread adds the PollEvent without waiting for the
processing of the event to complete
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
