lianetm commented on code in PR #18737:
URL: https://github.com/apache/kafka/pull/18737#discussion_r1954500856
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerMembershipManagerTest.java:
##########
@@ -663,7 +663,7 @@ public void
testSameAssignmentReconciledAgainWithMissingTopic() {
// stay in RECONCILING state, since an unresolved topic is assigned
membershipManager.onHeartbeatSuccess(createConsumerGroupHeartbeatResponse(assignment1,
membershipManager.memberId()));
assertEquals(MemberState.RECONCILING, membershipManager.state());
- membershipManager.poll(time.milliseconds());
+ membershipManager.maybeReconcile(true);
Review Comment:
Hey, it's helpful only for the ones with no revocation needed, so I expect
they should pass with the reconcile attempt that cannot commit (ensures we're
not changing anything on the reconciliation of new partitions or the metadata
resolution).
We don't need to change all existing tests, just those. Let's start with the
ones I suggested here I would say. I did take a full pass yesterday when
reviewing and those are the ones to me, I could be missing one or two but not
too many I hope :) I'll take another pass after the next updates.
The rule in my mind is: iff the test does not revoke partitions,
maybeReconcile(false) should be enough to get everything reconciled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
