frankvicky commented on code in PR #18737:
URL: https://github.com/apache/kafka/pull/18737#discussion_r1954644723
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractMembershipManager.java:
##########
@@ -818,6 +826,8 @@ void maybeReconcile() {
return;
}
+ if (autoCommitEnabled && !canCommit) return;
Review Comment:
Yes, we could apply the same approach we use for auto-commit and auto-commit
on revocation. (`offsetsReady`)
While this has an obvious drawback of somewhat breaking the original design
separation between the app thread and background thread (where the app thread
handles user application logic and the background thread manages I/O and
networking), I believe it's a necessary trade-off.
Given there isn't a cleaner way to synchronize state and offset positions
between both threads, this approach, though not ideal, seems to be the best
solution available.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
