FrankYang0529 commented on code in PR #18997:
URL: https://github.com/apache/kafka/pull/18997#discussion_r1966401253
##########
metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java:
##########
@@ -753,6 +753,10 @@ public void testBalancePartitionLeaders() throws Throwable
{
QuorumController active = controlEnv.activeController();
Map<Integer, Long> brokerEpochs = new HashMap<>();
+ TestUtils.waitForCondition(() ->
+
active.featureControl().finalizedFeatures(Long.MAX_VALUE).featureMap().get(MetadataVersion.FEATURE_NAME)
== SIMPLE_BOOTSTRAP.metadataVersion().featureLevel(),
Review Comment:
Thanks for the suggestion. I think we can remove
`QuorumControllerTestEnv#activeController(boolean)` function, because it's
better for all cases get a real active controller. Other test cases like
`testUncleanShutdownBrokerElrEnabled` also has similar error.
<img width="1306" alt="Screenshot 2025-02-22 at 10 37 39 AM"
src="https://github.com/user-attachments/assets/f5e009e2-d788-4219-aeff-83dd72c9c78e";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
