ijuma commented on PR #18997: URL: https://github.com/apache/kafka/pull/18997#issuecomment-2676396427
> So, it does seem reasonable to initialize it to null. @cmccabe : What do you think? It looks like this would basically always be `null` outside of tests and it would fail in the following line of the `FeatureControlManager` constructor: > this.metadataVersion = new TimelineObject<>(snapshotRegistry, metadataVersion); It seems to me that we should actually remove the metadata version from `FeatureControlManager` and rely on `FeatureControlManager.replay` to set the metadata version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
