snehashisp commented on code in PR #17988:
URL: https://github.com/apache/kafka/pull/17988#discussion_r1996173318
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/PluginUtils.java:
##########
@@ -510,4 +512,16 @@ public static VersionRange
connectorVersionRequirement(String version) throws In
version = "[" + version + "]";
return VersionRange.createFromVersionSpec(version);
}
+
+ public static <T> String getVersionOrUndefined(T obj,
Function<ClassLoader, LoaderSwap> pluginLoaderSwapper) {
Review Comment:
Right, because task does not implement Versioned rather has explicitly
defines it as a interface method. Anyway, I removed this as per suggestion and
opted to used Plugins#PluginVersion instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]