gharris1727 commented on code in PR #17988:
URL: https://github.com/apache/kafka/pull/17988#discussion_r1996154736
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/entities/ConnectorStateInfo.java:
##########
@@ -87,14 +90,26 @@ public String workerId() {
public String trace() {
return trace;
}
+
+ @JsonProperty
+ @JsonInclude(JsonInclude.Include.NON_EMPTY)
Review Comment:
> Wdyt of just showing the version (even if its null or undefined) with
multi-versioning support.
I'm a bit ambivalent on explicit `null`s, I think the more important thing
to me is that `"null"` and `"undefined"` never appear in the results. That just
looks like poor data quality to my eyes.
> People who are unaware of the internals may be confused as to why its not
showing up at all if the version is not set.
Can you elaborate? What is the situation where this happens and how might it
mislead someone?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
