snehashisp commented on code in PR #17988:
URL: https://github.com/apache/kafka/pull/17988#discussion_r1996139231
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerTask.java:
##########
@@ -442,8 +456,51 @@ private void addRatioMetric(final State matchingState,
MetricNameTemplate templa
taskStateTimer.durationRatio(matchingState, now));
}
+ public void addPluginInfoMetric(TaskPluginsMetadata pluginsMetadata) {
+ ConnectMetricsRegistry registry = connectMetrics.registry();
+ metricGroup.addValueMetric(registry.taskConnectorClass, now ->
pluginsMetadata.connectorClass());
+ metricGroup.addValueMetric(registry.taskConnectorClassVersion, now
-> pluginsMetadata.connectorVersion());
+ metricGroup.addValueMetric(registry.taskConnectorType, now ->
pluginsMetadata.connectorType());
+ metricGroup.addValueMetric(registry.taskClass, now ->
pluginsMetadata.taskClass());
+ metricGroup.addValueMetric(registry.taskVersion, now ->
pluginsMetadata.taskVersion());
+ metricGroup.addValueMetric(registry.taskKeyConverterClass, now ->
pluginsMetadata.keyConverterClass());
+ metricGroup.addValueMetric(registry.taskKeyConverterVersion, now
-> pluginsMetadata.keyConverterVersion());
+ metricGroup.addValueMetric(registry.taskValueConverterClass, now
-> pluginsMetadata.valueConverterClass());
+ metricGroup.addValueMetric(registry.taskValueConverterVersion, now
-> pluginsMetadata.valueConverterVersion());
+ metricGroup.addValueMetric(registry.taskHeaderConverterClass, now
-> pluginsMetadata.headerConverterClass());
+ metricGroup.addValueMetric(registry.taskHeaderConverterVersion,
now -> pluginsMetadata.headerConverterVersion());
+
+ if (!pluginsMetadata.transformations().isEmpty()) {
+ for (TransformationStage.AliasedPluginInfo entry :
pluginsMetadata.transformations()) {
+ MetricGroup transformationGroup =
connectMetrics.group(registry.transformsGroupName(),
+ registry.connectorTagName(), id.connector(),
+ registry.taskTagName(),
Integer.toString(id.task()),
+ registry.transformsTagName(), entry.alias());
+ transformationGroup.close();
Review Comment:
On closer inspection this is not necessary. The groups should only be
created once during task creation. IIUC if a update introduces a new set of
transformations then the existing task should be stopped and its metric groups
closed before creation of a new WorkerTask and new set of groups.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
