AndrewJSchofield commented on code in PR #20049:
URL: https://github.com/apache/kafka/pull/20049#discussion_r2175122034
##########
clients/src/main/java/org/apache/kafka/clients/admin/AlterShareGroupOffsetsResult.java:
##########
@@ -68,22 +69,22 @@ public KafkaFuture<Void> partitionResult(final
TopicPartition partition) {
/**
* Return a future which succeeds if all the alter offsets succeed.
+ * If not, the first topic error shall be returned.
*/
public KafkaFuture<Void> all() {
return this.future.thenApply(topicPartitionErrorsMap -> {
List<TopicPartition> partitionsFailed =
topicPartitionErrorsMap.entrySet()
.stream()
- .filter(e -> e.getValue() != Errors.NONE)
+ .filter(e -> e.getValue() != null)
Review Comment:
I'll check it out before I merge, but the important difference here is in
`KafkaApis.scala`. For DeleteSGO, it already handled a non-zero error code. For
AlterSGO, that code was missing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
