AndrewJSchofield commented on code in PR #20049:
URL: https://github.com/apache/kafka/pull/20049#discussion_r2178035810
##########
clients/src/main/java/org/apache/kafka/clients/admin/AlterShareGroupOffsetsResult.java:
##########
@@ -68,22 +69,22 @@ public KafkaFuture<Void> partitionResult(final
TopicPartition partition) {
/**
* Return a future which succeeds if all the alter offsets succeed.
+ * If not, the first topic error shall be returned.
*/
public KafkaFuture<Void> all() {
return this.future.thenApply(topicPartitionErrorsMap -> {
List<TopicPartition> partitionsFailed =
topicPartitionErrorsMap.entrySet()
.stream()
- .filter(e -> e.getValue() != Errors.NONE)
+ .filter(e -> e.getValue() != null)
Review Comment:
Ah, sorry. I didn't read your comment accurately. The difference is that
AlterShareGroupOffsets can successfully pass back an error code, which is why
this is in terms of `ApiException` rather than `Errors`. For
`AlterConsumerGroupOffsets`, the RPC is actually `OffsetCommit` and this does
not have an `ErrorMessage` field at all. So, it cannot be fixed for consumer
groups until we have a version bump on the `OffsetCommit` RPC.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
