AndrewJSchofield commented on code in PR #20049:
URL: https://github.com/apache/kafka/pull/20049#discussion_r2178041486
##########
clients/src/main/java/org/apache/kafka/clients/admin/AlterShareGroupOffsetsResult.java:
##########
@@ -68,22 +69,22 @@ public KafkaFuture<Void> partitionResult(final
TopicPartition partition) {
/**
* Return a future which succeeds if all the alter offsets succeed.
+ * If not, the first topic error shall be returned.
*/
public KafkaFuture<Void> all() {
return this.future.thenApply(topicPartitionErrorsMap -> {
List<TopicPartition> partitionsFailed =
topicPartitionErrorsMap.entrySet()
.stream()
- .filter(e -> e.getValue() != Errors.NONE)
+ .filter(e -> e.getValue() != null)
.map(Map.Entry::getKey)
.collect(Collectors.toList());
Review Comment:
I'm not sure it matters here. The list in internal to this method, and it is
just converted to a string and appended to the exception message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
