mimaison commented on code in PR #20087:
URL: https://github.com/apache/kafka/pull/20087#discussion_r2191891591
##########
storage/src/main/java/org/apache/kafka/server/log/remote/quota/RLMQuotaManagerConfig.java:
##########
@@ -16,38 +16,16 @@
*/
package org.apache.kafka.server.log.remote.quota;
-public class RLMQuotaManagerConfig {
+/**
+ * Configuration settings for quota management
+ *
+ * @param quotaBytesPerSecond The quota in bytes per second
+ * @param numQuotaSamples The number of samples to retain in memory
+ * @param quotaWindowSizeSeconds The time span of each sample
+ */
+public record RLMQuotaManagerConfig(long quotaBytesPerSecond, int
numQuotaSamples, int quotaWindowSizeSeconds) {
public static final int INACTIVE_SENSOR_EXPIRATION_TIME_SECONDS = 3600;
- private final long quotaBytesPerSecond;
- private final int numQuotaSamples;
- private final int quotaWindowSizeSeconds;
-
- /**
- * Configuration settings for quota management
- *
- * @param quotaBytesPerSecond The quota in bytes per second
- * @param numQuotaSamples The number of samples to retain in memory
- * @param quotaWindowSizeSeconds The time span of each sample
- */
- public RLMQuotaManagerConfig(long quotaBytesPerSecond, int
numQuotaSamples, int quotaWindowSizeSeconds) {
- this.quotaBytesPerSecond = quotaBytesPerSecond;
- this.numQuotaSamples = numQuotaSamples;
- this.quotaWindowSizeSeconds = quotaWindowSizeSeconds;
- }
-
- public long quotaBytesPerSecond() {
- return quotaBytesPerSecond;
- }
-
- public int numQuotaSamples() {
- return numQuotaSamples;
- }
-
- public int quotaWindowSizeSeconds() {
- return quotaWindowSizeSeconds;
- }
-
@Override
public String toString() {
Review Comment:
I agree
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
