mimaison commented on code in PR #20087: URL: https://github.com/apache/kafka/pull/20087#discussion_r2191893189
########## storage/src/main/java/org/apache/kafka/storage/internals/log/LazyIndex.java: ########## @@ -100,13 +100,7 @@ public void closeHandler() { } } - private static class IndexValue<T extends AbstractIndex> implements IndexWrapper { - - private final T index; - - IndexValue(T index) { - this.index = index; - } + private record IndexValue<T extends AbstractIndex>(T index) implements IndexWrapper { Review Comment: Yeah it's a bit of a gray area. I'm happy to keep it as a regular class. I undid that change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org