TaiJuWu commented on code in PR #20068: URL: https://github.com/apache/kafka/pull/20068#discussion_r2199668697
########## core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala: ########## @@ -2850,6 +2851,21 @@ class PlaintextAdminIntegrationTest extends BaseAdminIntegrationTest { } } + def sleepMillisToPropagateMetadata(durationMs: Long, partition: TopicPartition): Unit = { Review Comment: From my understanding, this function make sure the leader is changed to each broker, if am wrong, please correct me so is there any reason why we don't integrate this condition to `changePreferredLeader`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org