TaiJuWu commented on code in PR #20068:
URL: https://github.com/apache/kafka/pull/20068#discussion_r2200218526


##########
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##########
@@ -2850,6 +2851,21 @@ class PlaintextAdminIntegrationTest extends 
BaseAdminIntegrationTest {
     }
   }
 
+  def sleepMillisToPropagateMetadata(durationMs: Long, partition: 
TopicPartition): Unit = {

Review Comment:
   Because there is no any real conditions to wait metadata propagation (you 
just wait a constant time), I think we can get real condition to wait.
   
   For example, we can wait all brokers' partition leader is same.
   We can do that by merging this function into `changePreferredLeader `.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to