jim0987795064 commented on code in PR #20068: URL: https://github.com/apache/kafka/pull/20068#discussion_r2203264595
########## core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala: ########## @@ -2963,9 +2981,11 @@ class PlaintextAdminIntegrationTest extends BaseAdminIntegrationTest { TestUtils.assertLeader(client, partition2, 2) // Now change the preferred leader to 1 + sleepMillisToPropagateMetadata(10000, partition2) Review Comment: Hello @chia7712 , after reviewing the waitForPartitionMetadata code, it seems that this API is used to check whether the partition leader broker is valid — that is, not -1 or unknown. It doesn't guarantee that all leader brokers are the same. When I run the code, the test still fails. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org