DL1231 commented on code in PR #20152:
URL: https://github.com/apache/kafka/pull/20152#discussion_r2202240436
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java:
##########
@@ -1407,7 +1408,8 @@ public GroupCoordinatorMetrics(Metrics metrics, String
metricGrpPrefix) {
this.metricGrpName,
"The number of successful rebalance events per hour, each
event is composed of " +
"several failed re-trials until it succeeded"),
- new Rate(TimeUnit.HOURS, new WindowedCount())
+ new Rate(TimeUnit.HOURS, new WindowedCount()),
+ new MetricConfig().timeWindow(1, TimeUnit.HOURS)
Review Comment:
I'm wondering if I might be overlooking something. Perhaps merely adjusting
the calculation method in `windowSize` won't resolve the issue. The root cause
lies in the time window being too short to retain data for the past hour, while
we need to know exactly how many rebalance have occurred within the last hour.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
