DL1231 commented on code in PR #20152:
URL: https://github.com/apache/kafka/pull/20152#discussion_r2202281405
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java:
##########
@@ -1407,7 +1408,8 @@ public GroupCoordinatorMetrics(Metrics metrics, String
metricGrpPrefix) {
this.metricGrpName,
"The number of successful rebalance events per hour, each
event is composed of " +
"several failed re-trials until it succeeded"),
- new Rate(TimeUnit.HOURS, new WindowedCount())
+ new Rate(TimeUnit.HOURS, new WindowedCount()),
+ new MetricConfig().timeWindow(1, TimeUnit.HOURS)
Review Comment:
I agree with your point, but an alternative approach might be to add a new
constructor in `MetricConfig` instead. This is because the Rate class itself
isn't aware of `MetricConfig` or `timeWindowMs`—it only receives this value as
a parameter when the method is called.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
