Yunyung commented on code in PR #20152:
URL: https://github.com/apache/kafka/pull/20152#discussion_r2202250159
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java:
##########
@@ -1407,7 +1408,8 @@ public GroupCoordinatorMetrics(Metrics metrics, String
metricGrpPrefix) {
this.metricGrpName,
"The number of successful rebalance events per hour, each
event is composed of " +
"several failed re-trials until it succeeded"),
- new Rate(TimeUnit.HOURS, new WindowedCount())
+ new Rate(TimeUnit.HOURS, new WindowedCount()),
+ new MetricConfig().timeWindow(1, TimeUnit.HOURS)
Review Comment:
The current problem is that `config.timeWindowMs` doesn’t behave as we
expected (hourly). However, modifying it would require changes to the entire
MetricsConfig for this metric.
My idea is to create a new constructor in `Rate` that allows `timeWindowMs`
to be set separately. If it’s specified, we use that value instead of the
default. Let’s see if there’s agreement or other ideas.
Additionally, I think other metrics using `config.timeWindowMs` besides
`Rate` might have the same issues.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
