kamalcph commented on PR #20203: URL: https://github.com/apache/kafka/pull/20203#issuecomment-3112382355
With this patch, RLMM#configure is called post the SocketServer initialization, this is required only for TBRLMM implementation as it has to create/read/write to the `__remote_log_metadata` topic. For other RLMM plugin impl, the `RLMM#configure` can be called before the SocketServer initialization if they don't keep the metadata in Kafka. Since, TBRLMM is packaged as default / out-of-the-box implementation, this approach looks good to me. Compared with and without this patch. Without patch, the `Admin` tries continuously until the server is ready: ``` % grep -c "Rebootstrapping with Cluster" nohup.out 6555 ``` With this patch, the `Admin` succeeds on the first try: ``` % grep -c "Rebootstrapping with Cluster" nohup.out.1 0 ``` The other approach #20231 is generic and allows any RLMM implementor to invoke broker based on the status. But, it requires KIP. @showuon / @FrankYang0529 Could you take a second pass? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
