jiafu1115 commented on PR #20203: URL: https://github.com/apache/kafka/pull/20203#issuecomment-3113732924
@kamalcph I read the current code implement and the KIP provided by @Yunyung . I think even current code is ok but it break the contract as he mentioned. If our user write one RemoteLogMetadataManager's implement which also implement Monitorable. And he won't can use the configure items to setup metric on Monitorable#withPluginMetrics. So maybe the original propose is better now though it will involve writing one KIP and more codes. WDTY? Or do we have some better idea? Thank you ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
