jiafu1115 commented on PR #20203:
URL: https://github.com/apache/kafka/pull/20203#issuecomment-3113544887

   > Thanks for the PR. Accroding to 
[KIP-877](https://cwiki.apache.org/confluence/x/lY3GDQ) "If a plugin implements 
this interface, the withPluginMetrics() method will be called when the plugin 
is instantiated (after configure() if the plugin also implements Configurable). 
"
   > 
   > So I think the current change breaks that contract.
   @Yunyung  thanks for your review. I will also take some time to understand 
the contract. BTW. Can you help to take a look at the original propose which I 
create another closed PR for example: 
https://github.com/apache/kafka/pull/20231/files
   WDTY for this one?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to