AndrewJSchofield commented on code in PR #20152:
URL: https://github.com/apache/kafka/pull/20152#discussion_r2239620491
##########
clients/src/main/java/org/apache/kafka/common/metrics/MetricConfig.java:
##########
@@ -43,6 +43,15 @@ public MetricConfig() {
this.recordingLevel = Sensor.RecordingLevel.INFO;
}
+ public MetricConfig(MetricConfig config) {
+ this.quota = config.quota;
+ this.samples = config.samples;
+ this.eventWindow = config.eventWindow;
+ this.timeWindowMs = config.timeWindowMs;
+ this.tags = config.tags;
Review Comment:
Being picky, this copy constructor is not copying the fields from the input
parameter. Shouldn't we create a copy of the quota and tags, for example?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
