Yunyung commented on PR #20152: URL: https://github.com/apache/kafka/pull/20152#issuecomment-3134906200
Thanks for the update. If the unit represents a larger time span than windowSizeMs, we always need to handle this case; otherwise the computed value will be incorrect. Shouldn’t we update the internal logic of Rate directly instead of relying on developers/user to know that they need to pass a new MetricConfig? Furthermore, this issue isn’t limited to `Rate`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org