chia7712 commented on code in PR #20466:
URL: https://github.com/apache/kafka/pull/20466#discussion_r2379690992
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java:
##########
@@ -69,6 +69,7 @@ public class GroupCoordinatorConfig {
Group.GroupType.CLASSIC.toString(),
Group.GroupType.CONSUMER.toString(),
Group.GroupType.STREAMS.toString());
+ public static final List<String>
GROUP_COORDINATOR_REBALANCE_PROTOCOLS_ALLOWED =
GROUP_COORDINATOR_REBALANCE_PROTOCOLS_DEFAULT;
Review Comment:
why not using `GROUP_COORDINATOR_REBALANCE_PROTOCOLS_DEFAULT` directly?
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java:
##########
@@ -298,7 +299,8 @@ public class GroupCoordinatorConfig {
public static final ConfigDef CONFIG_DEF = new ConfigDef()
// Group coordinator configs
.define(GROUP_COORDINATOR_REBALANCE_PROTOCOLS_CONFIG, LIST,
GROUP_COORDINATOR_REBALANCE_PROTOCOLS_DEFAULT,
- ConfigDef.ValidList.in(false,
Group.GroupType.documentValidValues()), MEDIUM,
GROUP_COORDINATOR_REBALANCE_PROTOCOLS_DOC)
+
ConfigDef.ValidList.in(GROUP_COORDINATOR_REBALANCE_PROTOCOLS_ALLOWED.toArray(new
String[0])),
Review Comment:
not sure why `share` is not controlled by
`group.coordinator.rebalance.protocols`? By contrast, `stream` and `consumer`
could be disabled by `group.coordinator.rebalance.protocols`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
